Animated WebP support #5470
Animated WebP support #5470
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5470-animated-webp |
|
Needed this feature for a project I'm working on, currently using this branch as a dependency. So as far as testing goes, everything has been working as expected. All the quirks I came across were ironed out pre-PR. |
examples/images/src/cat.webp
Outdated
There was a problem hiding this comment.
Let's make sure this is on git lfs
There was a problem hiding this comment.
I tried to fix this for you, but failed:
Pushing to github.com:Aely0/egui
error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'github.com:Aely0/egui'
You need to run this:
git lfs track examples/images/screenshot.png
git lfs track examples/images/src/cat.webp
git checkout .gitattributes
git add -u
git commit -m "Move images onto git lfs"
git push
There was a problem hiding this comment.
Done, though strange why you were not able to push to this branch
I thought that was the whole point of this checkbox
There was a problem hiding this comment.
This seems to be a limitation of git lfs:
|
We should add better instructions for how to solve this problem to the CI output and to |
Is it not what |
|
Oh, this part, "If the CI complains about this, make sure you run git add --renormalize .." |
Adds support for animated WebP images. Used the already existing GIF implementation as a template for most of it.